-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CS2103T-W13-1] EYLAH #33
Open
sheexiong
wants to merge
1,229
commits into
nus-cs2103-AY1920S2:master
Choose a base branch
from
AY1920S2-CS2103T-W13-1:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[CS2103T-W13-1] EYLAH #33
sheexiong
wants to merge
1,229
commits into
nus-cs2103-AY1920S2:master
from
AY1920S2-CS2103T-W13-1:master
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beatricetay
reviewed
Mar 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! You might want to remove the duplicated diagrams.
docs/UserGuide.adoc
Outdated
|
||
|
||
== Appendix A: Simple activity diagram to aid user with using Expense Splitter | ||
image::activityDiagram_for_expensesplitter.png[width="790"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- You might want to remove the '?'
- It might be better for the [Still have Item to add] arrow to point to the 'Add Item' bubble
- You might be missing another diamond connecting the first diamond and the 'ListAmount' before it ends.
Edited DG and UG
…branch-final-lap-changes
# Conflicts: # docs/UserGuide.adoc
Upload Screenshot.
…ting for additem, deleteitem, clearreceipt and donereceipt. Updated PPP
update UG to include success photos
Uploaded UG DT Photos.
Update Akhil PPP and update class diagrams
Update umldiagram submission file and userguid image.
Updated the expected outcome images. Added instruction for manual testing for additem, deleteitem, clearreceipt and donereceipt. Updated PPP.
DG i missed stuff out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ease Your Life At Halls
@WillySeahh @akhilvuputuri @Jarrod-Bob @ailanthustng